-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve the default theme viewer design #39049
[docs] Improve the default theme viewer design #39049
Conversation
Great improvement, it looks amazing! 🤙 I was wondering if we should add the switches to 'expand all' and 'use dark theme' to Joy UI too—and maybe polish out these a bit |
Absolutely! Having docs feature parity between the two + those switches not with default MD would be great! I'd need some engineering support there from the team (cc @noraleonte, @siriwatknp, @DiegoAndai) as I tried to do it myself for the last few here and found it to be kinda tricky 😬 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Left one comment.
@noraleonte Uhm... can you try again now? I've added Consolas as another font family, which seems to be the Windows default monospace family? As a meta note, for some reason, using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉 🤙
This PR adds a small uplift on the default viewer page design: tweaked the Tree View a bit and the page formatting (e.g., removing the table of contents)(both the Material UI & Joy Ui pages). It's been bothering me for a while that this very useful resource wasn't fitting in well with the docs current visuals... so, finally put in some time to polish it up a bit.