Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] Move @types/prop-types back to dependencies #39030

Merged
merged 1 commit into from
Sep 18, 2023
Merged

[utils] Move @types/prop-types back to dependencies #39030

merged 1 commit into from
Sep 18, 2023

Conversation

Methuselah96
Copy link
Contributor

Fixes #39029.

@mui-bot
Copy link

mui-bot commented Sep 17, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39030--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6debd35

@michaldudak michaldudak self-requested a review September 18, 2023 08:08
@michaldudak michaldudak added bug 🐛 Something doesn't work typescript package: utils Specific to the @mui/utils package regression A bug, but worse labels Sep 18, 2023
@michaldudak michaldudak changed the title [utils]: Move @types/prop-types back to dependencies [utils] Move @types/prop-types back to dependencies Sep 18, 2023
michaldudak
michaldudak approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@michaldudak michaldudak merged commit 135d00a into mui:master Sep 18, 2023
9 of 10 checks passed
@Methuselah96 Methuselah96 deleted the patch-1 branch September 18, 2023 11:24
danilo-leal pushed a commit to siriwatknp/material-ui that referenced this pull request Sep 18, 2023
@Methuselah96 @danilo-leal
[utils] Move @types/prop-types back to dependencies (mui#39030)
ff2bd78 
Signed-off-by: Nathan Bierema <[email protected]>
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
@Methuselah96 @christophermorin
[utils] Move @types/prop-types back to dependencies (mui#39030)
5218b9a 
Signed-off-by: Nathan Bierema <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work package: utils Specific to the @mui/utils package regression A bug, but worse typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[utils]: Missing dependency on @types/prop-types
3 participants
@Methuselah96 @mui-bot @michaldudak