[material-next][Button] Remove the ripple root element when ripple not active #39027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39027--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
danilo-leal
added
component: ButtonBase
mj12albert
added
design: material you
and removed
package: material-ui
mnajdova
requested changes
Oct 20, 2023
There was a problem hiding this comment.
This creates regression in the behavior, see:
Current pull request
Screen.Recording.2023-10-20.at.13.26.32.mov
Master:
Screen.Recording.2023-10-20.at.13.27.03.mov
I'd be curious to see what's the motivation for creating the pull request. We can them discuss potential solutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Button] remove the ripple root element when ripple not active