Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add Tailwind CSS + plain CSS demo on the Tabs page #39000

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

alisasanib
Copy link
Contributor

Part of #37222

@mui-bot
Copy link

mui-bot commented Sep 15, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against cb3393f

@mnajdova mnajdova added docs Improvements or additions to the documentation component: tabs This is the name of the generic UI component, not the React module! labels Sep 16, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dark mode the Tailwind CSS demo needs polish on the tab panels:

Screenshot 2023-09-16 at 07 18 15

import { Tab as BaseTab, TabProps } from '@mui/base/Tab';

export default function UnstyledTabsIntroduction() {
return (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a wrapping div here that will set the 'dark' classname in dark mode.

@alisasanib alisasanib requested a review from mnajdova September 18, 2023 15:55
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@mnajdova mnajdova merged commit a120ae5 into mui:master Sep 20, 2023
6 checks passed
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants