[docs][joy-ui] Revise the Drawer page #38988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewBundle size report |
danilo-leal
commented
Sep 15, 2023
| The Drawer can be cancelled by clicking the overlay or pressing the Esc key. | ||
| It closes when an item is selected, handled by controlling the `open` prop. | ||
| The Drawer can be closed by clicking on the overlay or pressing the <kbd>Esc</kbd> key. | ||
| It will also close if an item inside of it is selected, which can be controlled by the `open` prop. | ||
|
|
||
| {{"demo": "DrawerBasic.js"}} | ||
|
|
||
| ## Customization |
There was a problem hiding this comment.
@siriwatknp + @samuelsycamore should we say something / add a demo about modal vs. non-modal Drawers? I've seen plenty of use cases for both out there in the wild.
There was a problem hiding this comment.
I think that's a good idea!
There was a problem hiding this comment.
@mnajdova Is there anything specific we should do to get a non-modal Drawer? (Image Notion's comment drawer as an example of it).
|
Woo, thanks a ton for the reviews @samuelsycamore! I'll need either @mnajdova or @siriwatknp's help in adding these components to the API section ⎯ couldn't figure out how to do it 😅 |
siriwatknp
approved these changes
Sep 20, 2023
|
Just realized we forgot to add an Anatomy section to this page! 🤦♂️ We can come back to it in another PR. |
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a few increments and corrections here and there, as well as some demo tweaks.
Got some questions along the way that I'll drop as comments!
https://deploy-preview-38988--material-ui.netlify.app/joy-ui/react-drawer/