Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base-ui] Improve focus trap demo #38985

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 15, 2023

Something that I noticed during the review of #38878. It was hard to spot that the focus moved to the container.

Screen.Recording.2023-09-18.at.22.29.45.mov

https://deploy-preview-38985--material-ui.netlify.app/base-ui/react-focus-trap/

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: FocusTrap The React component. labels Sep 15, 2023
@mui-bot
Copy link

mui-bot commented Sep 15, 2023

Netlify deploy preview

https://deploy-preview-38985--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c5e3af8

@zannager zannager requested a review from mnajdova September 15, 2023 12:37
@oliviertassinari oliviertassinari merged commit c23c40a into mui:master Sep 24, 2023
6 checks passed
@oliviertassinari oliviertassinari deleted the focus-trap-polish-demos branch September 24, 2023 15:05
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: FocusTrap The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants