Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove react from styled-engine dependencies #38971

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

michaldudak
Copy link
Member

React has been added to @mui/styled-engine and @mui/styled-engine-sc dependencies by mistake. It should be a devDependency.

@michaldudak michaldudak added core Infrastructure work going on behind the scenes package: styled-engine Specific to @mui/styled-engine package: styled-engine-sc Specific to styled-components labels Sep 14, 2023
@michaldudak michaldudak requested a review from a team September 14, 2023 07:37
@mui-bot
Copy link

mui-bot commented Sep 14, 2023

Netlify deploy preview

https://deploy-preview-38971--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 7d86513

@michaldudak michaldudak merged commit d0c6dd3 into mui:master Sep 14, 2023
8 checks passed
@michaldudak michaldudak deleted the styled-engine-react-dep branch September 14, 2023 08:58
@ChananM
Copy link

ChananM commented Sep 14, 2023

Hey @michaldudak @Janpot , any idea when a new version with this fix will be deployed?
It breaks our entire company's UI

@mor-stampli
Copy link

mor-stampli commented Sep 14, 2023

Hi @michaldudak @Janpot ,
thanks for the patch.
we have got a major broken release because of this change.
when do you think it will be released?

@michaldudak
Copy link
Member Author

We usually do releases on Mondays. Please use the previous version until then.
Sorry for the inconvenience!

@msirghi
Copy link

msirghi commented Sep 14, 2023

Hi @michaldudak, this breaks our whole UI as well.

@ChananM, @mor-stampli, what error do you have?

@fake364
Copy link

fake364 commented Sep 14, 2023

@michaldudak Hi, I had happy time figuring out what was the problem during my overtime. When it will be fixed ?

@jpietroroia-practia
Copy link

A temporary fix can be made by adding an override of the version to the package.json of your project, example:

  "overrides": {
     "@mui/material": {
       "@mui/styled-engine": "5.14.7"
     }
   },

Thank you Marcelo Roses for this solution

@ChananM
Copy link

ChananM commented Sep 18, 2023

@msirghi Something incoherent about useContext and useState
We figured out it happened because we use a lower version of React than 18, and it broke the UI.
Unfortunately, we can't use the aforementioned temporary fix because we currently also use a low version of node / npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes package: styled-engine Specific to @mui/styled-engine package: styled-engine-sc Specific to styled-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants