[base-ui][useMenu] Align external props handling for useMenu/MenuButton/MenuItem #38946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: menu
8 tasks
Netlify deploy previewhttps://deploy-preview-38946--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
force-pushed
the
base/use-menu-external-props
branch
from
e1c4ef0 to
95926c1
Compare
mj12albert
force-pushed
the
base/use-menu-external-props
branch
from
95926c1 to
822d1e6
Compare
mj12albert
force-pushed
the
base/use-menu-external-props
branch
from
822d1e6 to
ca04f0f
Compare
mj12albert
requested review from
DiegoAndai
and removed request for
michaldudak
michaldudak
approved these changes
Sep 19, 2023
christophermorin
pushed a commit
to christophermorin/material-ui
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38186
This PR aligns the typing/handling of external props for
useMenu,useMenuButtonanduseMenuItem, and adds some simple tests