Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][base-ui] Renaming demos to BaseXxx #38924

Closed
wants to merge 53 commits into from
Closed

[docs][base-ui] Renaming demos to BaseXxx #38924

wants to merge 53 commits into from

Conversation

christophermorin
Copy link
Contributor

@christophermorin christophermorin commented Sep 11, 2023 •
edited
Loading

One iteration toward solving #38904.

Demos changed in this PR:

  • Slider
  • Button

@mui-bot
Copy link

mui-bot commented Sep 11, 2023 •
edited
Loading

Netlify deploy preview

@material-ui/unstyled: parsed: +0.20% , gzip: +0.25%
@mui/material-next: parsed: +0.84% , gzip: +0.80%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 65e7fee

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Sep 11, 2023
oliviertassinari
oliviertassinari reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@christophermorin
Copy link
Contributor Author

christophermorin commented Sep 16, 2023 •
edited
Loading

Apologies for the clutter of merge and failed tests commits. I should be handling those locally, lessons learned.

I'll send up the remaining Button demo changes, and reach out for a 👍 to see if this is going down the right path.

@christophermorin
Copy link
Contributor Author

christophermorin commented Sep 18, 2023 •
edited
Loading

Opted to leave UseButton, and UnstyledButtonCustom demos unchanged as they use 'CustomButtonXxx' naming and their related docs seem to emphasize customization.

oliviertassinari and others added 16 commits September 21, 2023 20:12
@oliviertassinari @christophermorin
[website] Improve lighthouse score (mui#39011)
098bc90
@oliviertassinari @christophermorin
[docs] Fix number input wrong demo
31d2197
@sai6855 @christophermorin
[joy-ui][AccordionGroup] Fix console warning when using custom color (m…
650322b 
…ui#38950)
@mnajdova @christophermorin
[docs][Dialog] Add non-modal dialog docs & demo (mui#38684)
8488eae
@MonstraG @christophermorin
[docs][material-ui][Pagination] Add TablePagination to the API comp…
c145bf8 
…onents list (mui#38486)
@Methuselah96 @christophermorin
[utils] Move @types/prop-types back to dependencies (mui#39030)
5218b9a 
Signed-off-by: Nathan Bierema <[email protected]>
@michaldudak @christophermorin
[core] Move eslint to peer dependencies of eslint-plugin-material-ui (m…
fe5da06 
…ui#39033)
@mnajdova @christophermorin
[release] v5.14.10 (mui#39034)
d306556
@xcode-it @christophermorin
[docs][joy-ui] Add use-count-up integration with the Circular Progr…
3ad4f1f 
…ess (mui#38952)
@oliviertassinari @christophermorin
[docs-infra] Open demo crash in the right repository (mui#39006)
40a5aa1
@Janpot @christophermorin
[core] Add a comment to explain useEnhancedEffect (mui#39035)
2e5faca
@oliviertassinari @christophermorin
[TextareaAutosize] Simplify logic and add test (mui#38728)
9131d9f
@oliviertassinari @danilo-leal @christophermorin
[docs] Add live demo with CssVarsProvider (mui#38792)
40531ac 
Signed-off-by: Olivier Tassinari <[email protected]>
Co-authored-by: Danilo Leal <[email protected]>
@zanivan @christophermorin
[docs][joy-ui] Refine the Sign in template (mui#38942)
a35b69b
@gitstart @AsiwajuDev @christophermorin
[Select][material-ui] Missing aria-multiselectable attribute on multi…
dcae273 
…ple Select component (mui#38855)

Co-authored-by: AsiwajuDev <[email protected]>
@danilo-leal @christophermorin
[website] Add stray design tweaks to the X page (mui#38589)
9628e38
anle9650 and others added 27 commits September 21, 2023 20:12
@anle9650 @mj12albert
@samuelsycamore @christophermorin
[base-ui][NumberInput] Support adornments (mui#38900)
b5ce28a 
Signed-off-by: Andy Le <[email protected]>
Co-authored-by: Albert Yu <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
@mj12albert @christophermorin
[base-ui][useSelect][useOption] Align external props handling (mui#39038
6bbc4ea 
)
@flaviendelangle @christophermorin
[website] Small fixes on the X marketing page (mui#38975)
320f338
@renovate @christophermorin
Bump lerna to ^7.3.0 (mui#38778)
f7dd710 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump chai to ^4.3.8 (mui#38893)
295e94c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @types/babel__helper-module-imports to ^7.18.1 (mui#39015)
af1ceac 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @types/loader-utils to ^2.0.4 (mui#39019)
ba6976e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump webpack-cli to ^5.1.4 (mui#38784)
e941b19 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @types/node to ^18.17.18 (mui#39020)
4957760 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump rollup to ^3.29.2 (mui#39023)
a6dcdb9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@alisasanib @christophermorin
[docs][base] Add Tailwind CSS + plain CSS demo on the Tabs page (mui#…
820e3cd 
…39000)
@renovate @christophermorin
Bump @types/fs-extra to ^11.0.2 (mui#39018)
85f36e0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mj12albert @christophermorin
[base-ui][useMenu] Align external props handling for useMenu/MenuButt…
030c204 
…on/MenuItem (mui#38946)
@renovate @christophermorin
Bump @types/babel-plugin-macros to ^3.1.1 (mui#39013)
6aaee2e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @types/babel__traverse to ^7.20.2 (mui#39017)
7f18c38 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @types/doctrine to ^0.0.6 (mui#38886)
fa4cab9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump babel (mui#39021)
84b5969 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump styled-components to ^5.3.11 (mui#39024)
b4a28d7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump @DefinitelyTyped tools to ^0.0.178 (mui#39012)
66dd91d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump react-virtuoso to ^4.6.0 (mui#38898)
df0a306 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @christophermorin
Bump github/codeql-action action to v2.21.8 (mui#39022)
c518a6a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@michaldudak @christophermorin
[core] Update Babel types along with source packages (mui#39070)
99778ef
@renovate @christophermorin
Bump @types/babel__core to ^7.20.2 (mui#39014)
5da2dec 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mj12albert @christophermorin
[FormControl][material-next] Copy v5 FormControl (mui#39039)
9324e1c
@danilo-leal @christophermorin
[docs][joy-ui] Fix the Templates link on the Overview page (mui#39086)
695e3db
@danilo-leal @christophermorin
[docs][joy-ui] Simplify the button's loading indicator demo (mui#39082)
5a7d682
@christophermorin
Select demos renamed
65e7fee
@christophermorin
Copy link
Contributor Author

I seem to have broken this trying to figure out rebase and updating my feature branch, so for now I'm going to close it out.

@christophermorin christophermorin deleted the docs-base-ui-ISSUE-#38904 branch October 4, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.