-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release] v5.14.9 #38920
[release] v5.14.9 #38920
Conversation
Netlify deploy previewhttps://deploy-preview-38920--material-ui.netlify.app/ @material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
CHANGELOG.md
Outdated
|
||
A big thanks to the 15 contributors who made this release possible. Here are some highlights ✨: | ||
|
||
- 🎉 Added `Drawer` component to Joy UI (#38169) @mnajdova |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link to the docs could be great. Or maybe even an image/video preview. We are not selling it 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added link to the docs
@siriwatknp @zanivan, let me know if you have an image or video you wish to add 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree here about images or video clips. We can brag about new features on social media, but the changelog should be concise and highlight changes from the previous version. It's not a means of marketing.
A link is fine, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, a link is enough for the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't agree here about images or video clips. We can brag about new features on social media, but the changelog should be concise and highlight changes from the previous version. It's not a means of marketing.
@michaldudak There are different schools on this.
- Changelog first: https://github.com/prisma/prisma/releases, https://github.com/drizzle-team/drizzle-orm/releases,
- Twitter first: https://github.com/chakra-ui/chakra-ui/releases https://github.com/shadcn-ui/ui/releases
- Blog posts first: https://github.com/microsoft/TypeScript/releases, https://nextjs.org/blog, https://v5.mantine.dev/changelog/5-8-0/
- Doesn't announce
I feel the problem in our case is that we fall most often under "Doesn't announce" 😁. I would be much in favor of 3.
@DiegoAndai these PRs can be merged #38876 #38814 and maybe #38753 could also go |
"@mui/joy": "5.0.0-beta.6", | ||
"@mui/material": "^5.14.9", | ||
"@mui/material-next": "6.0.0-alpha.101", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off-topic: not sure why the system has them as dev dependencies 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependencies are now explicit, we use them in the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would challenge that having this here is a net-positive, I don't understand how #38859 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions look good to me, just a few open questions.
Signed-off-by: Zeeshan Tamboli <[email protected]>
I think I discovered the cause of the In #38859, the MUI packages were added explicitly to the root Running @michaldudak, how might we proceed here? |
Sorry for causing trouble. I'm attempting a fix in #38940. |
PR for the release of version
5.14.9