-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete][base-ui] Added ref to getInputProps return value #38919
Conversation
Netlify deploy previewhttps://deploy-preview-38919--material-ui.netlify.app/ Bundle size report |
@michaldudak @sai6855 can you please help me out, why my 3 checks failed? |
@DarhkVoyd The |
@michaldudak I have made necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It's a great first PR!
@michaldudak can you please guide me what's next? I would like to do more, where can I start? |
@DarhkVoyd feel free to browse the issues. We've got the |
The type of the UseAutocompleteReturnValue.getInputProps (in packages\mui-base\src\useAutocomplete\useAutocomplete.d.ts) needed to be extended and include the ref: React.Ref field.
Closes #36552