Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][useSlider] Align externalProps handling #38854

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 7, 2023

Part of #38186

Aligns the naming of externalProps: ExternalProps, and updates the order of some returned props based on #38679

@mui-bot
Copy link

mui-bot commented Sep 7, 2023

Netlify deploy preview

https://deploy-preview-38854--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f4fa2ce

@mj12albert mj12albert force-pushed the base/use-slider-external-props branch 3 times, most recently from 69864af to cddf32a Compare September 12, 2023 10:08
@mj12albert mj12albert added the component: slider This is the name of the generic UI component, not the React module! label Sep 12, 2023
@mj12albert mj12albert force-pushed the base/use-slider-external-props branch from cddf32a to ecf1368 Compare September 12, 2023 10:24
@mj12albert mj12albert force-pushed the base/use-slider-external-props branch from ecf1368 to f4fa2ce Compare September 25, 2023 07:26
@mj12albert mj12albert marked this pull request as ready for review September 25, 2023 07:57
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mj12albert mj12albert merged commit 2e9321f into mui:master Sep 27, 2023
9 checks passed
@mj12albert mj12albert deleted the base/use-slider-external-props branch September 27, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants