-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zero][next] Setup nextjs plugin package #38852
Conversation
Netlify deploy previewhttps://deploy-preview-38852--material-ui.netlify.app/ Bundle size report |
7b68a29
to
150b553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment left. The index page is a server component it is instantly loading, this is so exciting! :)
6e7a9b7
to
2e74c17
Compare
2e74c17
to
378533f
Compare
to use the zero-next-plugin
378533f
to
bf9c68c
Compare
10324d1
to
28eb2ab
Compare
28eb2ab
to
144ef9f
Compare
@@ -0,0 +1,64 @@ | |||
{ | |||
"name": "@mui/zero-next-plugin", | |||
"version": "0.0.1-alpha.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brijeshb42 this is a wrong version, we just created the package. Was it intentional so that it is the same version as the other zero-related packages? In my opinion they should anyway be all at version 0.0.1-alpha.3
until we release them publicly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It was set to match other zero package versions.
This PR creates -
zero-next-plugin
which is a next js plugin to be used in app'snext.config.js
. This package is a fork of next-with-linaria with added support of sx prop and@mui/zero-runtime/styles.css
import.app/zero-runtime-next-app
which uses the above plugin to add zero runtime support for styled tags.