Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zero][next] Setup nextjs plugin package #38852

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Sep 7, 2023

This PR creates -

  1. A package zero-next-plugin which is a next js plugin to be used in app's next.config.js. This package is a fork of next-with-linaria with added support of sx prop and @mui/zero-runtime/styles.css import.
  2. An app in app/zero-runtime-next-app which uses the above plugin to add zero runtime support for styled tags.

@brijeshb42 brijeshb42 added the package: system Specific to @mui/system label Sep 7, 2023
@brijeshb42 brijeshb42 requested a review from mnajdova September 7, 2023 08:29
@mui-bot
Copy link

mui-bot commented Sep 7, 2023

Netlify deploy preview

https://deploy-preview-38852--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 144ef9f

@brijeshb42 brijeshb42 force-pushed the zero-next-plugin branch 4 times, most recently from 7b68a29 to 150b553 Compare September 7, 2023 09:59
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 7, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment left. The index page is a server component it is instantly loading, this is so exciting! :)

packages/zero-next-plugin/src/index.ts Outdated Show resolved Hide resolved
@brijeshb42 brijeshb42 force-pushed the zero-next-plugin branch 2 times, most recently from 6e7a9b7 to 2e74c17 Compare September 11, 2023 11:45
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 13, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 14, 2023
@brijeshb42 brijeshb42 force-pushed the zero-next-plugin branch 4 times, most recently from 10324d1 to 28eb2ab Compare September 14, 2023 13:18
@brijeshb42 brijeshb42 requested a review from mnajdova September 15, 2023 05:43
@brijeshb42 brijeshb42 merged commit 93b3f9c into mui:master Sep 15, 2023
5 checks passed
@brijeshb42 brijeshb42 deleted the zero-next-plugin branch September 15, 2023 08:45
@@ -0,0 +1,64 @@
{
"name": "@mui/zero-next-plugin",
"version": "0.0.1-alpha.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brijeshb42 this is a wrong version, we just created the package. Was it intentional so that it is the same version as the other zero-related packages? In my opinion they should anyway be all at version 0.0.1-alpha.3 until we release them publicly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was set to match other zero package versions.

danilo-leal pushed a commit to siriwatknp/material-ui that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nextjs package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants