Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][useInput] Align ExternalProps naming #38849

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 7, 2023

Part of #38186

getRootProps and getInputProps are already forwarding external props, this PR just aligns the naming

@mj12albert mj12albert added the package: base-ui Specific to @mui/base label Sep 7, 2023
@mui-bot
Copy link

mui-bot commented Sep 7, 2023

Netlify deploy preview

https://deploy-preview-38849--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 44bd370

@mj12albert mj12albert marked this pull request as ready for review September 7, 2023 08:10
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@mj12albert mj12albert merged commit e6e5f8c into mui:master Sep 11, 2023
8 checks passed
@mj12albert mj12albert deleted the base/use-input-external-props branch September 11, 2023 07:21
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants