[base-ui][useList] Accept arbitrary external props and forward to root #38848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Netlify deploy previewhttps://deploy-preview-38848--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
force-pushed
the
base/use-list-external-props
branch
2 times, most recently
from
197df73 to
c2bd81d
Compare
mj12albert
force-pushed
the
base/use-list-external-props
branch
from
c2bd81d to
1f4a538
Compare
michaldudak
reviewed
Sep 8, 2023
|
@michaldudak I've fixed all the comments! |
michaldudak
reviewed
Sep 14, 2023
michaldudak
approved these changes
Sep 14, 2023
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: Albert Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38186
getRootPropsofuseListanduseListItemalready forwards external props, this PR just aligns the naming