Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Small revision to the Icons page #38840

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Sep 6, 2023

This PR was mostly for adding the new codeblock component for installation commands, but I couldn't resist some low-hanging stuff that I ended up tackling. There are many more writing opportunities here that we can improve in the future, though!

https://deploy-preview-38840--material-ui.netlify.app/material-ui/icons/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Sep 6, 2023
@danilo-leal danilo-leal self-assigned this Sep 6, 2023
@mui-bot
Copy link

mui-bot commented Sep 6, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3ed43bc

@danilo-leal
Copy link
Contributor Author

@samuelsycamore This is a trickier, less intuitive page to adapt to the new doc structure ⎯ I'm curious if you have a suggestion about how to apply it!

@danilo-leal
Copy link
Contributor Author

@samuelsycamore bumping this one up just because it's mostly a quick win! 😃 More thorough revision can come later.

Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This one is definitely going to need a deeper dive sooner or later, but we can come back to it.

@danilo-leal danilo-leal merged commit 75404f9 into mui:master Sep 27, 2023
6 checks passed
@danilo-leal danilo-leal deleted the small-revision-icons-page branch September 27, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

3 participants