[blog] Fix missing card #38834
Merged
[blog] Fix missing card #38834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38834--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
blog-card
branch
from
24a06c8 to
fe0d99d
Compare
samuelsycamore
approved these changes
Sep 6, 2023
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card. It's a follow-up on mui#38258. I think that we should be able to fail the build if the card is missing, but too lazy.
oliviertassinari
force-pushed
the
blog-card
branch
from
fe0d99d to
db2332a
Compare
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See how https://twitter.com/MUI_hq/status/1688919247504957440 doesn't have a card. It's a follow-up on #38258.
I've added an integrity check at the same time, so we can't regress on this. The build will fail if the card is missing.
In addition to missing social cards, there are also cards of wrong dimensions, for example, https://robolly.com/open-graph-preview/?url=https://mui.com/blog/mui-x-v6/ not matching https://www.notion.so/mui-org/Tips-for-high-quality-media-5a1686758f4f4267989b67a1c2c270da?pvs=4#1a714454a2554f1f8673e41284498833.
If we see more instances of this problem, I think we should use https://www.npmjs.com/package/image-size to guarantee the aspect ratio of 2:1.