Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix a11y issues in tables demos #38829

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

michaldudak
Copy link
Member

During work on #36287, the dependencies got updated, and ESLint started showing errors in some of the table demos. I couldn't pinpoint which dependency was responsible for this, but it's not super important. The issue was that some of the table cells (used to fill empty space) did not have an accessible label. I fixed it by making them invisible to assistive technologies (as they are just for presentation).

@michaldudak michaldudak added docs Improvements or additions to the documentation accessibility a11y labels Sep 6, 2023
@michaldudak michaldudak requested a review from mnajdova September 6, 2023 09:10
@mui-bot
Copy link

mui-bot commented Sep 6, 2023

Netlify deploy preview

https://deploy-preview-38829--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1baaed2

@michaldudak michaldudak merged commit 1a47213 into mui:master Sep 6, 2023
7 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@michaldudak michaldudak deleted the fix-a11y-issues branch January 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants