Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lab] Fix @mui/x-tree-view dependency #38822

Merged
merged 4 commits into from
Sep 6, 2023
Merged

[lab] Fix @mui/x-tree-view dependency #38822

merged 4 commits into from
Sep 6, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 5, 2023 •
edited
Loading

Fixes #38819

@flaviendelangle flaviendelangle added package: lab Specific to @mui/lab component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! regression A bug, but worse labels Sep 5, 2023
@flaviendelangle flaviendelangle self-assigned this Sep 5, 2023
@flaviendelangle flaviendelangle changed the title [lab] Fix tree view dependecy [lab] Fix @mui/x-tree-view dependecy Sep 5, 2023
@flaviendelangle flaviendelangle changed the title [lab] Fix @mui/x-tree-view dependecy [lab] Fix @mui/x-tree-view dependency Sep 5, 2023
mnajdova
mnajdova approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we intend to update this version with each release? Or is this solely to ease up the migration?

@flaviendelangle
Copy link
Member Author

Do we intend to update this version with each release? Or is this solely to ease up the migration?

I think we should do the same as for the pickers.
We pin the version and don't update it so that people have to migrate to X to get the new fixes (and we can do breaking changes without impacting the lab).

@mui-bot
Copy link

mui-bot commented Sep 6, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38822--material-ui.netlify.app/

@material-ui/lab: parsed: -0.13% 😍, gzip: -0.19% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 903bb79

@mnajdova
Copy link
Member

mnajdova commented Sep 6, 2023

We pin the version and don't update it so that people have to migrate to X to get the new fixes (and we can do breaking changes without impacting the lab).

Sounds good 👍

@flaviendelangle flaviendelangle merged commit ca5ac14 into mui:master Sep 6, 2023
5 checks passed
@flaviendelangle flaviendelangle deleted the lab-tree-view branch September 6, 2023 09:02
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@flaviendelangle @mnajdova
[lab] Fix @mui/x-tree-view dependency (mui#38822)
02559e1
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@flaviendelangle @mnajdova
[lab] Fix @mui/x-tree-view dependency (mui#38822)
672706a
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@flaviendelangle @xcode-it
[lab] Fix @mui/x-tree-view dependency (mui#38822)
65c2896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@PizzaPete PizzaPete PizzaPete approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! package: lab Specific to @mui/lab regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TreeView][lab] Unable to update @mui/[email protected]
4 participants
@flaviendelangle @mui-bot @mnajdova @PizzaPete