-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Refine the Messages template #38807
Conversation
Netlify deploy previewhttps://deploy-preview-38807--material-ui.netlify.app/ Bundle size report |
Hey thanks for the feedback! It's probably due to the usage of |
@zanivan Please see the fix in 93994c5, the root cause is that, Before <li>
<div role="button">
<li>…</li> {/* this is wrong */}
</div>
</li> After <li>
<div role="button">
<div>…</div>
</div>
</li> For nested list, it must follow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I'm excited to see more templates getting refined! 🤘
Some things I noticed we could improve:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Refining the Messages template, aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.
Part of #38582
https://deploy-preview-38807--material-ui.netlify.app/joy-ui/getting-started/templates/messages/