[examples] Add Next.js 13 compatible version of Link adapter #38797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
|
@mnajdova Do you think we should keep the previous Link adapter components and maybe rename to |
1 task
|
|
||
| The first version of the adapter is the [`NextLinkComposed`](https://github.com/mui/material-ui/blob/-/examples/material-ui-nextjs-ts/src/Link.tsx) component. | ||
| This component is unstyled and only responsible for handling the navigation. | ||
| The prop `href` was renamed `to` to avoid a naming conflict. |
There was a problem hiding this comment.
It might be preferable to cut this line or rephrase it to avoid confusion—the context for it being "renamed" is not present here, so a casual user might not know what to make of it.
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
docs/material-routing
branch
from
1d3877c to
bdbd6e6
Compare
github-actions
bot
removed
the
PR: out-of-date
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Linkadapter components for Next.js to the app router example repo.In Next.js 13 it is no longer required to manually provide
<a>as a child to Next'sLink(vercel/next.js#36436)(The changes here are extracted from #38243)