[NumberInput][base-ui] Warn when changing control mode with useControlled
#38757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
package: base-ui
Netlify deploy previewhttps://deploy-preview-38757--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
|
Off topic can we return isControlled boolean in |
mj12albert
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Looks good ~ thanks for working on this
@sai6855 Note that this will need to be handled differently once the internal state is refactored with useControllableReducer 😬
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #38513