[base-ui] Fix passing custom handlers to the root of Dialog #38745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38745--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
saeedShamloo
force-pushed
the
custom-event-handlers-modal
branch
2 times, most recently
from
89934ec to
75eb6ef
Compare
saeedShamloo
force-pushed
the
custom-event-handlers-modal
branch
from
75eb6ef to
8d0957a
Compare
|
Thank you for the pull request, but the issue was already addressed in #38868 and will be included in the upcoming release. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see in the following picture there is a warning in the console by
react-domabout custom event handlers onDialogcomponent:We can fix the warning by filtering the custom event handlers on the props that we are passing to the root component.