[TabScrollButton] Extend ButtonBase types

[ZeeshanTamboli]

• I have followed (at least) the PR section of the contributing guide.

I saw this while working on #38717. The TabScrollButton component uses ButtonBase, but it doesn't support its prop types.

Before: https://codesandbox.io/s/great-goldwasser-kqk4sz?file=/src/App.tsx
After: https://codesandbox.io/s/strange-shannon-tdy27s

Open the codesandboxes in full screen to get the scroll buttons.

[mui-bot]

Netlify deploy preview

https://deploy-preview-38719--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fa84948

[DiegoAndai]

The change looks good to me but a question came up. InternalStandardProps was replaced and the types it provides now come from CommonProps and ComponentPropsWithRef. My question is, is InternalStandardProps still useful or should we look into removing it?

[ZeeshanTamboli]

is InternalStandardProps still useful or should we look into removing it?

I think it remains helpful for components aiming to eliminate conflicts between props and standard HTML attributes. For instance, in the Tooltip component, it prevents the title attribute of HTMLDivElement from conflicting with the title prop of Tooltip.

While we could directly extend div attributes without StandardProps like:

export interface TooltipProps extends React.HTMLAttributes<HTMLDivElement> {

because style, ref, and className are already present in HTMLDivElement:

<div style={{ color: 'red' }} className="root" />

the second argument of StandardProps (Removals parameter) still appears beneficial.

Moreover, it also eliminates the extended component's classes type. For instance, in OutlinedInput, without StandardProps, the classes of the outlined input might be overridden by the Input base classes.

---

EDIT:

Moreover, it also eliminates the extended component's classes type. For instance, in OutlinedInput, without StandardProps, the classes of the outlined input might be overridden by the Input base classes.

Looks like this is not the case because the original classes type will override the extended ones (outlined input classes will override Input Base classes), but I still think it is useful to not define dual classes type.

[DiegoAndai]

Thanks for looking into my question 😊