[joy-ui][theme] Improve theme builder exceptions #38709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38709--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
danilo-leal
added
package: joy-ui
|
Hey @jyash97 thanks for the submission! I'll ask for the team to take a look at this. In the meantime, could you provide an example of what's happening? It can be a video or screenshot, so I can try reproducing it here. |
|
Hey @zanivan Attaching 2 videos of the current issues theme-token-crash.movrandom-color.mov |
siriwatknp
approved these changes
Sep 4, 2023
siriwatknp
added
docs
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
As of now if you add a color string in theme and remove it, it breaks the UI
We can add token with empty names and invalid color
I have followed (at least) the PR section of the contributing guide.