Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zero][vite] Create a package for vite plugin #38685

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

brijeshb42
Copy link
Contributor

This internally wraps linaria's vite plugin with ability to generate
theme CSS file as well.

@brijeshb42 brijeshb42 requested a review from mnajdova August 28, 2023 13:32
@brijeshb42 brijeshb42 added the package: system Specific to @mui/system label Aug 28, 2023
@mui-bot
Copy link

mui-bot commented Aug 28, 2023

Netlify deploy preview

https://deploy-preview-38685--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1fa5f4c

@brijeshb42 brijeshb42 force-pushed the zero-vite-plugin branch 3 times, most recently from fe8d0f6 to 250590d Compare September 4, 2023 15:51
This internally wraps linaria's vite plugin with ability to generate
theme CSS file as well.
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev & prod builds worked as expected 👍

apps/zero-runtime-vite-app/vite.config.ts Outdated Show resolved Hide resolved
@brijeshb42 brijeshb42 merged commit 076c4c3 into mui:master Sep 6, 2023
5 checks passed
@brijeshb42 brijeshb42 deleted the zero-vite-plugin branch September 6, 2023 07:25
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants