[joy-ui] Reduce height of some variants #38527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
package: joy-ui
Netlify deploy previewhttps://deploy-preview-38527--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
This comment was marked as resolved.
This comment was marked as resolved.
siriwatknp
reviewed
Aug 21, 2023
zanivan
changed the title
1 task
zanivan
commented
Aug 23, 2023
siriwatknp
force-pushed
the
joy-ui-sizes
branch
from
a634103 to
7e51c31
Compare
Hmm I don’t know. With all the other components denser, it might look too heavy and therefore feels a bit off. I was drawing inspiration from other libraries as shadcn, radix and mostly reshaped, where the |
siriwatknp
requested changes
Sep 7, 2023
siriwatknp
approved these changes
Sep 7, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Co-authored-by: siriwatknp <[email protected]>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 8, 2023
Co-authored-by: siriwatknp <[email protected]>
xcode-it
pushed a commit
to xcode-it/material-ui
that referenced
this pull request
Sep 11, 2023
Co-authored-by: siriwatknp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38418
Default theme should use the
mdvariant as much as possible, so instead of changing the default variant, I reduced theminHeightofmdvariants from2.5remto2.25remand added some stray tweaks to make things more consistent.The components with sizes reduced:
Moreover, I've taken the liberty to make some fine-tuning to other sizes as well.