[Menu][joy] Remove open and onClose props
#38354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: menu
Netlify deploy previewhttps://deploy-preview-38354--material-ui.netlify.app/ Bundle size report |
michaldudak
force-pushed
the
joy-controlled-menu
branch
from
1a3c817 to
2f8b9c5
Compare
|
@michaldudak Is this mean that |
|
Yes. If there are use cases where it would be needed, we can think about how to implement it. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
@siriwatknp, if the explicit use of the Dropdown is not desired, you can use a pattern similar to what's in #38934 - a wrapper component that uses |
github-actions
bot
added
the
PR: out-of-date
|
@siriwatknp, do you think this PR still makes sense, or should we discard it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openandonCloseprops are no longer exposed by the Menu component. It is now the responsibility of the Dropdown to control the open/close state. These props were inadvertently omitted when implementing the Dropdown.This is a part of the attempt to solve a problem described in #38324.