Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Add a general round of polish to the API content display #38282

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 2, 2023

This PR adds some small changes to further polish the API content display:

  • Delegate spacing to the Divider by removing the unnecessary marginBottom: 36 and therefore balancing it out more.
  • Alignment tweaks on the item note (i.e. "Required", "State").
  • Remove the "Description" heading from Slot descriptions to make it consistent with prop descriptions.
  • Remove the duplicate divider on the Slots section.

https://deploy-preview-38282--material-ui.netlify.app/joy-ui/api/aspect-ratio/

Before After
Screen Shot 2023-08-02 at 09 40 37 Screen Shot 2023-08-02 at 09 40 57
Screen Shot 2023-08-02 at 09 41 40 Screen Shot 2023-08-02 at 09 41 25
Screen Shot 2023-08-02 at 09 47 56 Screen Shot 2023-08-02 at 09 48 03

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Aug 2, 2023
@danilo-leal danilo-leal self-assigned this Aug 2, 2023
@mui-bot
Copy link

mui-bot commented Aug 2, 2023

Netlify deploy preview

https://deploy-preview-38282--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f0290cb

@danilo-leal danilo-leal merged commit 888b318 into master Aug 2, 2023
@danilo-leal danilo-leal deleted the api-content-display-polish branch August 2, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

3 participants