Bump eslint-plugin-react to ^7.33.2 #38117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Netlify deploy previewhttps://deploy-preview-38117--material-ui.netlify.app/ Bundle size report |
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
43f6b21 to
b7b8656
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
b7b8656 to
2cd6fc9
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
2cd6fc9 to
f00c315
Compare
github-actions
bot
added
the
PR: out-of-date
renovate
bot
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
f00c315 to
b44e74b
Compare
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
michaldudak
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
82a63c6 to
074783a
Compare
github-actions
bot
removed
the
PR: out-of-date
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
michaldudak
reviewed
Sep 20, 2023
test/utils/createMount.tsx
Outdated
| @@ -85,6 +85,7 @@ export default function createMount(options: CreateMountOptions = {}) { | |||
|
|
|||
| afterEach(() => { | |||
| ReactDOMTestUtils.act(() => { | |||
| // eslint-disable-next-line react/no-deprecated | |||
There was a problem hiding this comment.
I couldn't make it work. This could be caused by the lack of Enzyme support for React 18.
michaldudak
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
074783a to
d9928d4
Compare
michaldudak
force-pushed
the
renovate/eslint-plugin-react-7.x
branch
from
d9928d4 to
d154127
Compare
michaldudak
reviewed
Sep 22, 2023
| return () => { | ||
| ReactDOM.unmountComponentAtNode(viewerRoot); | ||
| clearTimeout(renderTimeout); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
React tree can't be synchronously unmounted during render, so I introduced setTimeout to run this code after React lifecycle completes. Taken from https://stackoverflow.com/questions/73459382/react-18-async-way-to-unmount-root#answer-74445760
Janpot
reviewed
Sep 22, 2023
| @@ -26,6 +26,8 @@ describe('elementAcceptingRef', () => { | |||
| function testAct() { | |||
| checkPropType(element); | |||
| if (shouldMount) { | |||
| // TODO: replace with React 18 implementation after https://github.com/testing-library/react-testing-library/issues/1216 is closed. | |||
There was a problem hiding this comment.
Purely out of curiosity, did you try it with testing-library/react-testing-library#1216 (comment)?
There was a problem hiding this comment.
Yes, it works with that version.
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Sep 25, 2023
Co-authored-by: Michał Dudak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.32.2->^7.33.2Release Notes
jsx-eslint/eslint-plugin-react (eslint-plugin-react)
v7.33.2Compare Source
Fixed
no-deprecated]: prevent false positive on commonjs import (#3614 @akulsr0)no-unsafe]: report on the method instead of the entire component (@ljharb)no-deprecated]: report on the destructured property instead of the entire variable declarator (@ljharb)no-deprecated]: report on the imported specifier instead of the entire import statement (@ljharb)no-invalid-html-attribute]: report more granularly (@ljharb)v7.33.1Compare Source
Fixed
require-default-props]: fix config schema (#3605 @controversial)jsx-curly-brace-presence]: Revert [#3538][] due to issues with intended string type casting usage (#3611 @taozhou-glean)sort-prop-types]: ensure sort-prop-types respects noSortAlphabetically (#3610 @caesar1030)v7.33.0Compare Source
Added
display-name]: addcheckContextObjectsoption (#3529 @JulesBlm)jsx-first-prop-new-line]: addmultipropoption (#3533 @haydncomley)no-deprecated]: add React 18 deprecations (#3548 @sergei-startsev)forbid-component-props]: adddisallowedForoption (#3417 @jacketwpbb)Fixed
no-array-index-key]: consider flatMap (#3530 @k-yle)jsx-curly-brace-presence]: handle single and only expression template literals (#3538 @taozhou-glean)no-unknown-property]: allowonLoadonsource(@ljharb)jsx-first-prop-new-line]: ensure autofix preserves generics in component name (#3546 @ljharb)no-unknown-property]: allowfillprop on<symbol>(#3555 @stefanprobst)display-name], [prop-types]: when checking for a capitalized name, ignore underscores entirely (#3560 @ljharb)no-unused-state]: avoid crashing on a class field function with destructured state (#3568 @ljharb)no-unused-prop-types]: allow using spread with object expression in jsx (#3570 @akulsr0)destructuring-assignment]: Handle destructuring of useContext in SFC" (#3583 [#2797][] @102)prefer-read-only-props]: add TS support (#3593 @HenryBrown0)Changed
jsx-newline], [no-unsafe], [static-property-placement]: Fix code syntax highlighting (#3563 @nbsp1221)jsx-no-bind]: reword performance rationale (#3581 @gpoole)jsx-first-prop-new-line]: add missingmultipropvalue (#3598 @dzek69)Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.