Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextareaAutosize] Fix 166ms resize update lag #37135

Merged

Conversation

amal-qb
Copy link
Contributor

@amal-qb amal-qb commented May 2, 2023

@mui-bot
Copy link

mui-bot commented May 2, 2023

Netlify deploy preview

https://deploy-preview-37135--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against ccf26d7

@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label May 2, 2023
@zannager zannager requested a review from michaldudak May 2, 2023 13:54
@amal-qb
Copy link
Contributor Author

amal-qb commented May 8, 2023

@michaldudak Can you please review and merge this PR?

@amal-qb
Copy link
Contributor Author

amal-qb commented May 23, 2023

Hi @michaldudak ,
Can you review this please?

@michaldudak
Copy link
Member

The issue is still present (although not as apparent as before). I suggest removing debounce from the handleResize call.

@amal-qb
Copy link
Contributor Author

amal-qb commented Jul 28, 2023

@michaldudak I have removed debounce from handleResize call. Sorry for committing the fix so late.

@amal-qb
Copy link
Contributor Author

amal-qb commented Aug 8, 2023

@michaldudak Can you please review the changes?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Aug 10, 2023

@amal-qb Can you please merge with the latest master branch so that all the CI jobs run?

@amal-qb
Copy link
Contributor Author

amal-qb commented Aug 11, 2023

@ZeeshanTamboli Done

@amal-qb amal-qb requested a review from michaldudak August 30, 2023 07:25
@michaldudak
Copy link
Member

Thanks for the fix!

@michaldudak michaldudak merged commit e788009 into mui:master Aug 30, 2023
@oliviertassinari oliviertassinari added component: TextareaAutosize The React component. package: base-ui Specific to @mui/base bug 🐛 Something doesn't work labels Aug 30, 2023
@oliviertassinari oliviertassinari changed the title [TextField] Fix unstable height of memoized multiline TextField component [TextareaAutosize] Fix 166ms resize update lag Aug 30, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@oliviertassinari
Copy link
Member

Test case added in #38728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! component: TextareaAutosize The React component. package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextareaAutosize] Instability in height of memoized multiline TextField component
6 participants