Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Next.js examples v13 - fonts #34971

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

PetroSilenius
Copy link
Contributor

Background 📚

Relates to #34898

Next.js v13 introduces a brand new font system which automatically optimizes your fonts and makes using Google fonts super convinient. This feature is currently in beta

Next.js v13 release blog post
Next.js font optimization docs
@next/font API reference

This feature is currently in beta but could improve the font loading experience already today. Multiple fontWeigths aren't yet supported without multiple individual font variables, vercel/next.js#41969

If we feel like the pull request is too early and should wait for a stable @next/font release then this could be turned into a draft and brought back later

Changes 🕹

@mui-bot
Copy link

mui-bot commented Oct 31, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-34971--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against a8f3293

@zannager zannager added the examples Relating to /examples label Nov 1, 2022
@zannager zannager requested a review from mnajdova November 1, 2022 05:56
@mnajdova
Copy link
Member

mnajdova commented Nov 1, 2022

Thanks for looking into this, I would personally wait for the support for multiple weight - vercel/next.js#41969 (comment)

@mnajdova mnajdova added the on hold There is a blocker, we need to wait label Nov 1, 2022
@Sandeep06Dev
Copy link
Contributor

Thanks for looking into this, I would personally wait for the support for multiple weight - vercel/next.js#41969 (comment)

Multiple weights and styles are available now vercel/next.js#41969 (comment)

@PetroSilenius
Copy link
Contributor Author

Multiple weights and styles are available now vercel/next.js#41969 (comment)

Thanks for the catch Sandeep! Updated to use multiple weights now so the the same four Roboto font weights are now loaded

@mnajdova
Copy link
Member

mnajdova commented Nov 2, 2022

Multiple weights and styles are available now vercel/next.js#41969 (comment)

Thanks for the catch Sandeep! Updated to use multiple weights now so the the same four Roboto font weights are now loaded

That's great! @PetroSilenius please ping me when you will have a chance to update the PR.

@PetroSilenius
Copy link
Contributor Author

@mnajdova ajdova I already updated to use multiple font weights in 52801f7 or is there some other changes needed?

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnajdova ajdova I already updated to use multiple font weights in 52801f7 or is there some other changes needed?

Sorry, I've missed the last commit. I left couple of comments for consideration.

@mnajdova mnajdova removed the on hold There is a blocker, we need to wait label Nov 2, 2022
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mnajdova mnajdova merged commit fc04701 into mui:master Nov 3, 2022
@PetroSilenius PetroSilenius deleted the nextjs-example-v13-fonts branch November 3, 2022 07:08
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples nextjs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants