-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Next.js examples v13 - fonts #34971
Conversation
|
Thanks for looking into this, I would personally wait for the support for multiple weight - vercel/next.js#41969 (comment) |
Multiple weights and styles are available now vercel/next.js#41969 (comment) |
Thanks for the catch Sandeep! Updated to use multiple weights now so the the same four Roboto font weights are now loaded |
That's great! @PetroSilenius please ping me when you will have a chance to update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Background 📚
Relates to #34898
Next.js v13 introduces a brand new font system which automatically optimizes your fonts and makes using Google fonts super convinient. This feature is currently in beta
Next.js v13 release blog post
Next.js font optimization docs
@next/font API reference
This feature is currently in beta but could improve the font loading experience already today. Multiple fontWeigths aren't yet supported without multiple individual font variables, vercel/next.js#41969
If we feel like the pull request is too early and should wait for a stable
@next/font
release then this could be turned into a draft and brought back laterChanges 🕹
Install
@next/font
packageUse
@next/font
for loading fonts instead of a link stylesheetI have followed (at least) the PR section of the contributing guide.