-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drawer] Allow clicks under closed persistent Drawer #30015
[Drawer] Allow clicks under closed persistent Drawer #30015
Conversation
Stops right-anchored persistent drawers from intercepting the mouse when they are closed.
As I was the one suggesting the changes, I would wait someone else to review the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution looks ok to me.
Side note:
It's a bit weird that the Drawer renders a wide element even when it's closed. Perhaps we can change it to collapse entirely in the future, so the problem solved by this PR would not exist at all (this would be a breaking change, though).
This was my biggest worry, but I agree. Should we add it to our v6 milestone? |
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are broken screenshot tests, looks like this is not the most ideal solution to the problem. We will need to investigate more and see what would be the best fix for it.
I am closing the PR, we can re-start the effort once we find a better solution to the problem |
Stops right-anchored persistent drawers from intercepting the mouse when
they are closed.
Tested fix in docs:
persistent-drawer-bug-fixed.mp4
Fixes #29997