Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styled-engine] Remove unecessary aliases #27779

Merged
merged 3 commits into from
Aug 17, 2021
Merged

[styled-engine] Remove unecessary aliases #27779

merged 3 commits into from
Aug 17, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 15, 2021 •
edited
Loading

I have noticed this in #27776. The value of removing the alias is to fail sooner. I have made one commit for each removal to explain why.

@oliviertassinari oliviertassinari added the package: styled-engine Specific to @mui/styled-engine label Aug 15, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 15, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against b900226

@oliviertassinari oliviertassinari mentioned this pull request Aug 15, 2021
Closed
9 tasks
mnajdova
mnajdova approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

eps1lon
eps1lon requested changes Aug 16, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why it is unnecessary? It's not clear what you mean by "fail sooner". When and why is this a good thing?

docs/src/modules/utils/helpers.ts Show resolved Hide resolved
@oliviertassinari oliviertassinari merged commit 1821e6b into mui:next Aug 17, 2021
@oliviertassinari oliviertassinari deleted the remove-sc-alias branch August 17, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
package: styled-engine Specific to @mui/styled-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-pr-bot @mnajdova @eps1lon