[core] Improve instructions for the @material-ui/styles migration #27466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
commented
Jul 27, 2021
| @@ -298,6 +290,14 @@ const pages: readonly MuiPage[] = [ | |||
| { pathname: '/guides/flow' }, | |||
| ], | |||
| }, | |||
| { | |||
| pathname: '/styles', | |||
There was a problem hiding this comment.
Moving this as last item in the sidebar, we don't want developers to read it unless they have legacy code from v4.
oliviertassinari
added
package: styles
Co-authored-by: Olivier Tassinari <[email protected]>
Co-authored-by: Olivier Tassinari <[email protected]>
1 task
siriwatknp
approved these changes
Jul 28, 2021
siriwatknp
reviewed
Jul 28, 2021
Co-authored-by: Siriwat K <[email protected]>
mnajdova
commented
Jul 28, 2021
|
I've pushed one more commit 30bc5d9 for fixing the imports on the advanced page. I think it's good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done in the PR:
@material-ui/stylespackage that it is a legacy and recommends using the @material-ui/system packagemakeStyles,withStylesandwithThemeutilities that throw Errors with links to the migration guideCloses #27216
Preview: https://deploy-preview-27466--material-ui.netlify.app/styles/basics/