[ToggleButton] Add color prop #25390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.16% , gzip: +0.05% |
oliviertassinari
added
component: toggle button
There was a problem hiding this comment.
I have updated the PR with the following:
- Rename the default value of the color away from "default". This is related to [RFC] color prop API #13028.
- Prepare the support of any colors
- Fix the CI
- Simplify the tests
- Increase the CSS specificity for pseudo-classes
- Update the docs side panel
- Update the usage of the design token to increase consistency and to fit a bit better the spec (seems to)
Regarding what's left:
- I wonder if we shouldn't do
action->text.primary? - I believe we have the addition of a new demo in the documentation :)
oliviertassinari
force-pushed
the
ToggleButton/add-color-prop
branch
from
a9c7643 to
5524f88
Compare
oliviertassinari
force-pushed
the
ToggleButton/add-color-prop
branch
from
d2141ee to
5c7c7ec
Compare
oliviertassinari
force-pushed
the
ToggleButton/add-color-prop
branch
from
5c7c7ec to
77bdfc0
Compare
oliviertassinari
approved these changes
Mar 19, 2021
oliviertassinari
approved these changes
Mar 19, 2021
|
Thanks @oliviertassinari, you did most of the work. 😃 |
|
@AlfredoGJ Hopefully, the changes that I have done make sense and can be leveraged for future contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my approach to fix #23755