Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Using disabled opacity from the theme #22570

Merged
merged 1 commit into from
Sep 13, 2020
Merged

[theme] Using disabled opacity from the theme #22570

merged 1 commit into from
Sep 13, 2020

Conversation

LorenzHenk
Copy link

Part of #22532 & #19343

I've found this code snippet, what should I do with it? https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/InputBase/InputBase.js#L20

Where does 0.42 come from?

@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Sep 12, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 53cbead

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 12, 2020 •
edited
Loading

https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/InputBase/InputBase.js#L20

We could create a new theme.palette.text.placeholder value in the theme but not sure if it's relevant as never share with other components. It's mean to be lighter than theme.palette.text.secondary. Related: #22537.

@github-actions github-actions bot mentioned this pull request Sep 12, 2020
Closed
@oliviertassinari oliviertassinari changed the title [core] Remove hardcoded opacity values [theme] Remove hardcoded opacity values Sep 13, 2020
@oliviertassinari oliviertassinari changed the title [theme] Remove hardcoded opacity values [theme] Using disabled opacity from the theme Sep 13, 2020
@oliviertassinari oliviertassinari merged commit ef46781 into mui:next Sep 13, 2020
@oliviertassinari
Copy link
Member

@LorenzHenk Thanks!

@LorenzHenk LorenzHenk deleted the issue-19343-hardcoded branch September 13, 2020 19:49
@oliviertassinari oliviertassinari mentioned this pull request Sep 14, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LorenzHenk @mui-pr-bot @oliviertassinari