-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove compose helper #16429
[docs] Remove compose helper #16429
Conversation
f15d611
to
61c82de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is a smoke screen for another change.
@eps1lon Do you mean #16380 (comment)? I have noticed the potential for improvement migrating the Ad component from the classes to hooks. It was simpler to bake the change here directly. I believe that we don't need more than one char |
61c82de
to
17ea9f6
Compare
Details of bundle changes.Comparing: 7fe530f...f2b702f
|
17ea9f6
to
2022490
Compare
I have moved the ad icon change into a different pull request: #16438. |
2022490
to
f2b702f
Compare
rebased. |
Kill docs/src/modules/utils/compose.js, this has been a problem for people copy & pasting the onepirate premium theme (#14604). This is also one step closer to a full hook codebase.
I appreciate how it reduces the overall number of LOCs.