-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkbox] Make Checkbox Button Animated #15687
Conversation
Yes, i cannot use clip-path since it doesnt work on my iphone, and i also heard it's not supported on IE or edge. EDIT: The svg says it works on all browsers, so i'd have to rewrite these animatons to use the svg version instead. |
@imdaveead I'm curious, why did you close the pull request? |
it's going to be very hard to get it implemented to be like the spec and support browsers and not messy code. right now my branch has a very messy implementation (but it works, not sure on ie though), and i dont feel like fixing it up much. if you or anyone else wants to go for it, reopen this or use what i already got since what i got wasn't total garbage, i decided to keep it in a "collection of random plugins" repo as a npm package, since it fits my needs and i would like to use it in my own projects, where supporting everything is not very important. |
i was looking at how some other implementations did the animation, and discovered |
That was how I animated the SVG version of the outlined textfield component before the clever use of fieldset & legend was proposed. It works quite nicely. I can see that being very efficient here given a checkmark based on a simple path. |
Did you check how quasar solves the problem? |
@oliviertassinari yes, i was inspecting the svg they used, and noticed some stroke related styles, which i didn't knew were available. i want to see if theres a easier way to animate the outline to filled square, which no one seems to have implemented. if not i'll probably just ignore it and fade in the box. either way i'm going to restart my work on this, and try to get a better version of it. |
@imdaveead That sounds great! |
Alternatively, we could, for now, fallback on the v0.x animation strategy. It works with custom icons too. |
This pull request gives the Radio buttons an animation, which follows the material design spec.
Motivations: #12639 and #15671
The animation is almost complete, but there are a few problems and questions.
clip-path
for the box and checkbox okay for performance and compatibility?I hope we can fix these issues and get this added.
and also, here's what it looks like.