Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwitchBase] Add a transition between checked and unchecked icons #13208

Closed
wants to merge 3 commits into from

Conversation

calebissharp
Copy link

@calebissharp calebissharp commented Oct 11, 2018

Uses the Fade component in SwitchBase to transition between checked and unchecked icons. This animation is disabled by default for Switch, as it really only applies to Radio and Checkbox.

switches

Resolves #12639.

@oliviertassinari oliviertassinari self-assigned this Nov 12, 2018
@eps1lon
Copy link
Member

eps1lon commented Dec 1, 2018

From looking at the spec it looks like

  • the checkmark in Checkbox is animated from left to right
  • the circle in Radio grows outwards
  • the handle in Switch translates horizontal (which it already does)

I would prefer the right (or at least close to) transition instead of just any.

@eps1lon eps1lon added design: material This is about Material Design, please involve a visual or UX designer in the process component: checkbox This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! labels Dec 1, 2018
@oliviertassinari oliviertassinari removed their assignment Dec 8, 2018
@mbrookes
Copy link
Member

mbrookes commented Feb 5, 2019

@calebissharp Thanks for working on this, it was a great first pass, but as it's been a while without progress, lets close for now. You're more than welcome to open a new PR an time!

@mbrookes mbrookes closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants