[Pagination] getItemAriaLabel is called with a wrong page type: end-ellipsis

[muhammetsait]

Duplicates

• I have searched the existing issues

Latest version

• I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/laughing-shamir-jncgvx?file=/src/App.tsx
Steps:

1. Pass getItemAriaLabel to Pagination component.
2. The total number of pages need to be high enough to render the ellipsis

Current behavior 😯

getItemAriaLabel is called with type start-ellipsis or end-ellipsis

Expected behavior 🤔

Don't call getItemAriaLabel for the ellipsis items, or fix the parameter type definition

Context 🔦

No response

Your environment 🌎

No response

[ZeeshanTamboli]

Thank you for the report. We need to correct the type parameter of getItemAriaLabel. By default, we don't apply the aria-label to the ellipsis items, but we provide the type for the ellipsis in case a custom aria-label is used with getItemAriaLabel. Here's the fix:

--- a/packages/mui-material/src/Pagination/Pagination.d.ts
+++ b/packages/mui-material/src/Pagination/Pagination.d.ts
@@ -41,16 +41,12 @@ export interface PaginationProps
    * This is important for screen reader users.
    *
    * For localization purposes, you can use the provided [translations](/material-ui/guides/localization/).
-   * @param {string} type The link or button type to format ('page' | 'first' | 'last' | 'next' | 'previous'). Defaults
to 'page'.
+   * @param {string} type The link or button type to format ('page' | 'first' | 'last' | 'next' | 'previous' | 'start-el
lipsis' | 'end-ellipsis'). Defaults to 'page'.
    * @param {number} page The page number to format.
    * @param {bool} selected If true, the current page is selected.
    * @returns {string}
    */
-  getItemAriaLabel?: (
-    type: 'page' | 'first' | 'last' | 'next' | 'previous',
-    page: number,
-    selected: boolean,
-  ) => string;
+  getItemAriaLabel?: (type: UsePaginationItem['type'], page: number, selected: boolean) => string;
   /**
    * Render the item.
    * @param {PaginationRenderItemParams} params The props to spread on a PaginationItem.

Would you to create a pull request to fix this?

[imSanko]

Can I try to work this issue @ZeeshanTamboli

[ZeeshanTamboli]

@imSanko Feel free to.