Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove workspace dependencies from root package.json #38940

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

michaldudak
Copy link
Member

As noted in #38920 (comment), yarn + lerna, unlike pnpm, don't work well with root package.json having dependencies to subprojects. Since this is not strictly required for yarn, I'm removing these dependencies from package.json.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Sep 12, 2023
@michaldudak michaldudak mentioned this pull request Sep 12, 2023
@mui-bot
Copy link

mui-bot commented Sep 12, 2023

Netlify deploy preview

https://deploy-preview-38940--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 415e769

@DiegoAndai
Copy link
Member

DiegoAndai commented Sep 12, 2023

Maybe this is not necessary? If we're moving to pnpm, updating the versions manually until we migrate from yarn is not that bad. What do you think?

@michaldudak
Copy link
Member Author

The pnpm PR has these added anyway, so removing them for now is better if yarn doesn't support them.

@DiegoAndai DiegoAndai merged commit 1409d6c into mui:master Sep 13, 2023
6 checks passed
@michaldudak michaldudak deleted the remove-root-workspace-deps branch September 14, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants