Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy-ui] Integrate a count-up feature to the Circular Progress #38739

Closed
wants to merge 22 commits into from
Closed

[docs][joy-ui] Integrate a count-up feature to the Circular Progress #38739

wants to merge 22 commits into from

Conversation

xcode-it
Copy link
Contributor

@xcode-it xcode-it commented Aug 31, 2023 •
edited
Loading

@mui-bot
Copy link

mui-bot commented Aug 31, 2023 •
edited
Loading

Netlify deploy preview

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against d22c32b

@xcode-it
Copy link
Contributor Author

@siriwatknp @zanivan

Issue #38682

@zannager zannager added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Aug 31, 2023
@zannager zannager requested a review from siriwatknp August 31, 2023 13:44
@zanivan
Copy link
Contributor

zanivan commented Sep 1, 2023

Hey @anon-phantom thanks so much for the submission! 🙌

I took the liberty to reorder the circular-progress.md file to be more consistent with the other docs, since this fits better under the 'common examples' section. I also made a few changes to the demo, mostly visual, but it'd be great if @siriwatknp could take a look before merging it 😄

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2023
danilo-leal
danilo-leal reviewed Sep 11, 2023
View reviewed changes
docs/public/static/logo.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and the file below, shouldn't be here. 🤔 Don't know how they got picked up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an old commit, from this PR

strange though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove it?

removed...

undo-logo-refinement

@xcode-it xcode-it mentioned this pull request Sep 12, 2023
Closed
1 task
@danilo-leal
Copy link
Contributor

Hey @anon-phantom, really appreciate you making the effort here! It seems the logo's commit is still here, though 😕 I think it'd be probably cleaner to start from scratch. Would you mind opening a new PR from zero with these changes added in?

@xcode-it
Copy link
Contributor Author

Hey @anon-phantom, really appreciate you making the effort here! It seems the logo's commit is still here, though 😕 I think it'd be probably cleaner to start from scratch. Would you mind opening a new PR from zero with these changes added in?

  • created a new PR

@xcode-it
Copy link
Contributor Author

created a new PR from scratch, as per some issues with this PR.

@xcode-it xcode-it closed this Sep 13, 2023
@xcode-it xcode-it deleted the circular-progress-count-up-feature branch September 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xcode-it @mui-bot @zanivan @danilo-leal @zannager