-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Refine the Profile Dashboard template #38599
Conversation
Netlify deploy previewhttps://deploy-preview-38599--material-ui.netlify.app/ Bundle size report |
@siriwatknp this was an old template inspired by an asset from Untitled UI kit, but I don't know if this still makes sense. Should we remove the reference now that's revamped and looks way different from before? |
The top and bottom spacing for the |
@siriwatknp are there any specific reason to replace the |
Mainly, accessibility. The navigation should be |
dangerfile.ts
Outdated
@@ -1,7 +1,7 @@ | |||
// inspire by reacts dangerfile | |||
// danger has to be the first thing required! | |||
import { danger, markdown } from 'danger'; | |||
import { exec } from 'child_process'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zanivan I think this change should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zanivan Great job! I really like the new look of the template, especially the shadow of the form controls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, yet another sweet improvement to the existing templates! Many of the things I had noticed the last time I saw it a few days ago were fixed already, so I'm left with just a couple of tiny stuff, none of which are blockers for moving forward, I think:
- The profile tabs (e.g., "Settings", etc.) seem to be missing the hover state. We could also round the top corners a bit.
- This might be on the component level (and not on the template), but inputs also seem to be missing hover styles. Like, I find it a bit weird that the Timezone select has and everything else doesn't. To verify if that's already correct and just not working here for some reason (similarly above).
- I think we could add a top divider on the gray container holding the "Cancel" and "Save" buttons! Just a bit of polish.
I don't know if it's a bug, but the only tab without a hover state is the
This seems to be an issue on the component level. The |
Co-authored-by: siriwatknp <[email protected]>
Co-authored-by: siriwatknp <[email protected]>
Co-authored-by: siriwatknp <[email protected]>
Refining the Order Dashboard template aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.
Part of #38582
https://deploy-preview-38599--material-ui.netlify.app/joy-ui/getting-started/templates/profile-dashboard/