Skip to content

Commit

Permalink
[Tabs] Fix crash when used with React 18 & Suspense (#33277)
Browse files Browse the repository at this point in the history
  • Loading branch information
mnajdova authored Jun 24, 2022
1 parent e93f876 commit 66ff196
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions packages/mui-material/src/Tabs/Tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,16 @@ const Tabs = React.forwardRef(function Tabs(inProps, ref) {

React.useEffect(() => {
const handleResize = debounce(() => {
updateIndicatorState();
updateScrollButtonState();
// If the Tabs component is replaced by Suspense with a fallback, the last
// ResizeObserver's handler that runs because of the change in the layout is trying to
// access a dom node that is no longer there (as the fallback component is being shown instead).
// See https://github.com/mui/material-ui/issues/33276
// TODO: Add tests that will ensure the component is not failing when
// replaced by Suspense with a fallback, once React is updated to version 18
if (tabsRef.current) {
updateIndicatorState();
updateScrollButtonState();
}
});
const win = ownerWindow(tabsRef.current);
win.addEventListener('resize', handleResize);
Expand Down

0 comments on commit 66ff196

Please sign in to comment.