Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[이상조] 9장: 실용주의 프로젝트 #81

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[이상조] 9장: 실용주의 프로젝트 #81

merged 1 commit into from
Sep 11, 2024

Conversation

sjoleee
Copy link
Member

@sjoleee sjoleee commented Sep 10, 2024

ㅂㅇ

@sjoleee sjoleee self-assigned this Sep 10, 2024
@github-actions github-actions bot added the 9장 label Sep 10, 2024
hyesungoh
hyesungoh approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

9장/이상조.md
내 의도는 어떠한 숫자가 들어와도 잘 동작하는 함수니까 랜덤한 값으로 테스트하면 그 의미도 더 명확하게 드러나지 않을까? + 고정된 특정 값으로만 테스트한다면 어떠한 숫자가 들어와도 잘 동작한다는걸 테스트할 수 있을까? 였는데...
리뷰로 랜덤 값으로 테스트하는 것이 옳은지에 대한 장문의 리뷰를 받았다.
요약하자면 대충 빌드타임에 돌리는 테스트는 이미 통과하는 테스트를 계속해서 통과하는지에 대한 테스트니까 랜덤값을 사용하면 안된다 였던 것 같다.
틀리는 테스트도 계속해서 틀려야 하겠다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@sjoleee sjoleee merged commit 0231ab6 into main Sep 11, 2024
1 check passed
@sjoleee sjoleee deleted the sjoleee-patch-2 branch September 11, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyesungoh hyesungoh hyesungoh approved these changes

@100Gyeon 100Gyeon Awaiting requested review from 100Gyeon 100Gyeon is a code owner

@Dongkyuuuu Dongkyuuuu Awaiting requested review from Dongkyuuuu Dongkyuuuu is a code owner

@gutenLEE gutenLEE Awaiting requested review from gutenLEE gutenLEE is a code owner

@metacode22 metacode22 Awaiting requested review from metacode22 metacode22 is a code owner

@Orchemi Orchemi Awaiting requested review from Orchemi Orchemi is a code owner

@sangbooom sangbooom Awaiting requested review from sangbooom sangbooom is a code owner

@Seojunhwan Seojunhwan Awaiting requested review from Seojunhwan Seojunhwan is a code owner

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011 sumi-0011 is a code owner

Assignees

@sjoleee sjoleee

Labels
9장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoleee @hyesungoh