Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangbooom
requested review from
hyesungoh,
100Gyeon,
Dongkyuuuu,
gutenLEE,
metacode22,
Orchemi,
Seojunhwan,
sjoleee and
sumi-0011
as code owners
100Gyeon
approved these changes
Aug 20, 2024
Comment on lines
+71
to
+72
| >  | ||
| > react-query 코어 내부 동작은 observer 인가 pub/sub 패턴 인가.. 둘 다 섞은 패턴일까? |
There was a problem hiding this comment.
저도 궁금해서 발표 끝나고 좀 더 찾아봤습니다..!
Observer와 다르게 Pub-Sub은 채널의 도움을 받는데
이 채널의 역할을 notifyManager가 해주고 있는 것 같아요
https://github.com/TanStack/query/blob/683c85e02c58c988cb520958941fcd163bd00eee/packages/query-core/src/queriesObserver.ts#L271
그래서 저는 Pub-Sub이라고 생각했습니다🤔
There was a problem hiding this comment.
어제 제 의견을 먼저 말씀드렸어야됐는데 못 드렸네요 😅 저도 지연님 의견과 동일한 이유로 pub-sub 이라고 생각했어요!
근데 'react-query 옵저버 패턴'이라고 하면 옵저버 패턴이라고 단언하는 블로그 글들이 나와서.. 제 생각과 다르더라구요 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.