Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[오혜성] 11장: Next.js 13과 리액트 18 #81

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[오혜성] 11장: Next.js 13과 리액트 18 #81

merged 2 commits into from
Feb 22, 2024

Conversation

hyesungoh
Copy link
Member

:godmode:

@hyesungoh hyesungoh self-assigned this Feb 12, 2024
@github-actions github-actions bot added the 11장 label Feb 12, 2024
Seojunhwan
Seojunhwan approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@Seojunhwan Seojunhwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!

11장/오혜성.md
Comment on lines +108 to +110
> 🤘 책에서 2023년 5월 기준으로는 타입스크립트가 비동기 컴포넌트를 지원하지 않았다고 하는데
> 타입스크립트 5.1.3. @types/react 18.2.8 에서는 지원한다 합니다
> https://nextjs.org/docs/app/building-your-application/configuring/typescript#async-server-component-typescript-error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러분들 타입스크립트 버전 어떤 거 쓰고 계셔요? 저희는 4.7.3?,,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희도 4... 4.8.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.1.6...

11장/오혜성.md
Comment on lines +165 to +167
> 🤘 실사용 코드보면서 저는 심적 표상을 잡는 편인데 ...
> https://github.com/gabrielelpidio/next-infinite-scroll-server-actions
> 이게 기억이 나 남겨봅니다..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오옹

sensecodevalue
sensecodevalue approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@sensecodevalue sensecodevalue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

11장/오혜성.md
Comment on lines +74 to +77
* 이후에는 서버 사이드 렌더링과 서버 컴포넌트를 모두 채택하는 것도 가능해질 것

* 결론적으로 둘은 대체제가 아닌 상호보완하는 개념
+ 리액트 팀에서도 미래에는 두 가지 기법이 모두 쓰일 수 있는 가능성을 암시하고 있음
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next 공식문서를 확인하지 않았지만 최초 로딩시에 dom을 내려주는것으로 보아 지금도 어느정도 같이 사용하는게 아닌가 예측중입니다!

@hyesungoh hyesungoh merged commit c5cfe83 into main Feb 22, 2024
1 check passed
@hyesungoh hyesungoh deleted the 11장/오혜성 branch February 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sensecodevalue sensecodevalue sensecodevalue approved these changes

@Seojunhwan Seojunhwan Seojunhwan approved these changes

@Dongkyuuuu Dongkyuuuu Awaiting requested review from Dongkyuuuu Dongkyuuuu is a code owner

@eunddodi eunddodi Awaiting requested review from eunddodi eunddodi is a code owner

@oyeon-kwon oyeon-kwon Awaiting requested review from oyeon-kwon oyeon-kwon is a code owner

@sjoleee sjoleee Awaiting requested review from sjoleee sjoleee is a code owner

@WooWan WooWan Awaiting requested review from WooWan WooWan is a code owner

Assignees

@hyesungoh hyesungoh

Labels
11장
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyesungoh @sensecodevalue @Seojunhwan @eunddodi