add support for GOARCH=wasm (include GOOS=wasip1) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
termenv compiles where
GOOS=js, but fails withGOOS=wasip1(https://go.dev/blog/wasi). This patch treats wasip1 as js, which for these purposes should be correct.I was able to run the tests on wasip1 by installing wazero and setting
WASMRUNTIME=wazero. The tests failed, when I first ran them, but it looks like the tests make assumptions that would fail for all of the_othertargets. This patch also "fixes" the tests (it skips one I wasn't sure how to rewrite for this platform).A project I'm working on imports this library as a transitive dependency, without this termenv does not build on GOOS=wasip1.
I decided to target wasm rather than js and wasip1 because more GOOS values will probably be added for wasm in the future, but it seems unlikely that wasm will end up running full operating systems tag like 'unix' would apply to.