Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(welcome): do not list model twice if we have a config #3790

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mudler
Copy link
Owner

@mudler mudler commented Oct 11, 2024

Description

This seems to be a regression in #2773. If you try to install models from the gallery and navigate to the first page otherwise shows duplicated entries

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mudler mudler added bug Something isn't working regression labels Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 633d0ec
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/6709426bc296be0009381218
😎 Deploy Preview https://deploy-preview-3790--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mudler mudler merged commit a0f0505 into master Oct 11, 2024
31 checks passed
@mudler mudler deleted the fix/list_dup_models branch October 11, 2024 15:30
@dave-gray101
Copy link
Collaborator

@mudler I don't think this fix is correct: this code should already be a part of the list model service and should be controlled by the loose file policy parameter.

I'll take a look at it shortly and potentially provide a fix

@mudler
Copy link
Owner Author

mudler commented Oct 11, 2024

@mudler I don't think this fix is correct: this code should already be a part of the list model service and should be controlled by the loose file policy parameter.

agree 💯 , I got the impression indeed from your changeset that should have been included, but as I am already in the middle of other changes I couldn't deep dive on it, so I patched the old code back until that's properly solved (as I would like to cut a new tag because of #3789 ).

I'll take a look at it shortly and potentially provide a fix

great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants